Modernize plugin #943
Modernize plugin #943
Conversation
| [platform: 'linux', jdk: 17], | ||
| [platform: 'windows', jdk: 11], |
There was a problem hiding this comment.
Following the archetype: Linux JDK 17, Windows JDK 11.
| @@ -2,6 +2,6 @@ | |||
| <extension> | |||
| <groupId>io.jenkins.tools.incrementals</groupId> | |||
| <artifactId>git-changelist-maven-extension</artifactId> | |||
| <version>1.0-beta-5</version> | |||
| <version>1.6</version> | |||
There was a problem hiding this comment.
Latest version at the time of this writing.
| @@ -4,7 +4,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.51</version> | |||
| <version>4.63</version> | |||
There was a problem hiding this comment.
Latest version at the time of this writing. Requires 2.361.1 or later and Java 11.
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| <name>Docker plugin</name> | |||
| <description>Provide Cloud Provisioning and other Docker features</description> | |||
| <url>https://github.com/jenkinsci/docker-plugin</url> | |||
| <url>https://github.com/jenkinsci/${project.artifactId}</url> | |||
| @@ -55,8 +55,7 @@ | |||
| <properties> | |||
| <revision>1.3.1</revision> | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
There was a problem hiding this comment.
No longer needed in the latest parent POM.
| <groupId>com.github.docker-java</groupId> | ||
| <artifactId>docker-java-transport-httpclient5</artifactId> | ||
| <version>3.2.13</version> | ||
| <version>3.2.13-68.va_875df25a_b_45</version> |
There was a problem hiding this comment.
Latest at the time of this writing.
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>docker-commons</artifactId> | ||
| <version>1.18</version> | ||
| <version>419.v8e3cd84ef49c</version> |
There was a problem hiding this comment.
Latest at the time of this writing.
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest</artifactId> | ||
| <version>2.2</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
pom.xml
Outdated
| <artifactId>bom-2.361.x</artifactId> | ||
| <version>2081.v85885a_d2e5c5</version> |
There was a problem hiding this comment.
Latest at the time of this writing.
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | ||
| <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection> | ||
| <url>https://github.com/${gitHubRepo}</url> |
|
Used my admin powers to replay the build with the |
| String vmargs = jnlpLauncher.vmargs; | ||
| if (StringUtils.isNotBlank(vmargs)) { | ||
| DockerEnvUtils.addEnvToCmd("JAVA_OPT", vmargs.trim(), cmd); | ||
| } |
There was a problem hiding this comment.
As of jenkinsci/jenkins#6543 vmargs is no longer supported, so this is dead code (along with the corresponding tests).
To test this PR I did a build on a Docker agent.