Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Java 8 #1356

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Removing Java 8 #1356

merged 3 commits into from
Jun 25, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 19, 2022

Implementing Proposal A for adapting jenkinsci/docker to the removal of Java 8. Proposal A is not as elegant as Proposal B, so this PR is intended to be a fallback in case no implementation of Proposal B materializes over the coming month.

@dduportal
Copy link
Contributor

@timja could you trigger the build of this PR? Since neither @basil or I are member of the repo, Jenkins uses the Jenkinsfile from the principal branch (message ‘Jenkinsfile’ has been modified in an untrusted revision in the build logs) so the changes proposed there are not picked up.

@timja
Copy link
Member

timja commented May 25, 2022

@timja could you trigger the build of this PR? Since neither @basil or I are member of the repo, Jenkins uses the Jenkinsfile from the principal branch (message ‘Jenkinsfile’ has been modified in an untrusted revision in the build logs) so the changes proposed there are not picked up.

I couldn't see any way for me to trigger it and make it trusted.
I tried:

  • pushing an empty commit
  • modifying the Jenkinsfile
  • clicking build now

Creating my own PR seemed to do it though:
#1357

@timja
Copy link
Member

timja commented May 25, 2022

@basil / @dduportal also happy to grant write access if you'll be doing any more CI changes just let me know

e.g. if @dduportal you plan to try doing this via a flag in docker bake for proposal B

@timja timja marked this pull request as ready for review June 25, 2022 07:33
@timja timja requested a review from a team as a code owner June 25, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants