forked from awslabs/ec2-spot-jenkins-plugin
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade min jenkins core and plugins versions #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only took a few tries... |
imuqtadir
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for fixing the tests. Ideally would have liked if you opened two PRs for your changes — version change and fixing tests 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the Jenkins core version from 2.112 to 2.222.4. Many other plugins will not work with core versions less than 2.222.4 anymore, for example this is causing an error here: https://github.com/jenkinsci/ec2-fleet-plugin/pull/273/checks?check_run_id=3352856751
Also upgrades the plugins version too
(edit)
Ended up having to expand the scope of this change:
upgraded core to 2.235.5 after seeing this on the Jenkins website:
Added the Jenkins Core BOM (https://github.com/jenkinsci/bom) to help manage dependency versions
Stripped the "LTS" builds out of the Jenkinsfile because they failed to build and I didn't see a recommendation that it needed to be used (https://github.com/jenkins-infra/pipeline-library)
Updated the developers list to an accurate state
Updated tests to remove deprecated API
Updated UI tests to support new UI location for clouds
and for extra credit (because they caused the builds to fail randomly on jenkins.io)