Modify logs for clarity #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes some of the log messages and comments to make formats more consistent and hopefully provide more clarity
One example of motivation for this change is the logs in schedule to terminate: previously they said "Attempting to terminate..." when they were really just adding instance ids to a list and not making the API call to terminate.
Another big part of this is adjusting the log levels. I adjusted them in a way I thought would divide normal operations (info level) from debug information (fine level). I'm hoping this gives users better information for normal operation, but we'll probably have to ask people to provide the fine level logs to be able to debug anything. Open to suggestions here.