Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't provison for null job labels when using restrictUsage #283

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Don't provison for null job labels when using restrictUsage #283

merged 2 commits into from
Aug 30, 2021

Conversation

haugenj
Copy link

@haugenj haugenj commented Aug 27, 2021

Fixes #277

  • Honor the restrictUsage parameter when checking canProvision()
  • Add tests for canProvision() that didn't exist
  • Fix log statement that was using fleet name instead of job label

imuqtadir
imuqtadir approved these changes Aug 27, 2021
View reviewed changes
Copy link

@imuqtadir imuqtadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@haugenj haugenj merged commit f720147 into jenkinsci:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imuqtadir imuqtadir imuqtadir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unspecified jobs will trigger ec2 fleet to provision
2 participants
@haugenj @imuqtadir