Fix save configuration to avoid resetting build counts #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the user modifies any configuration setting, the plugin resets the build counts back to
maxTotalBuild. After debugging, I found that we refer to old cloud object forCloudNannywhich triggers the plugin to re-add already existing node within Jenkins. This bug probably existed for the longest time however it never affected anything until we addmaxTotalBuildfeature.More details: When we run
update(), the cloud object (this) continues to refer to old cloud object in it's initial run (probably because it was scheduled during/prior the configuration save process) whileEC2FleetNodeis already re-assigned with the latest cloud object. This causes us to re-add the node hence resetting the build counts. Theupdate()fixes itself in subsequent run however the re-add process is already done by then. This usually happens when the cloud status interval i set low (~5 seconds). The constructor initialization takes around ~3 seconds which results inupdate()and initialization to happen around the same time.