Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin parent POM and BOM #314

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

basil
Copy link
Member

@basil basil commented Nov 26, 2021

Updates various plugin build metadata to more recent versions.

@basil basil force-pushed the refresh branch 2 times, most recently from a82cc1c to e1adf53 Compare November 27, 2021 03:09
Copy link

@imuqtadir imuqtadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@imuqtadir imuqtadir merged commit 01d4419 into jenkinsci:master Dec 3, 2021
@basil basil deleted the refresh branch December 3, 2021 17:05
@basil
Copy link
Member Author

basil commented Dec 3, 2021

Thanks! @imuqtadir note that when you release this you'll need to make sure you can git push to an HTTPS URL; otherwise you'll need to make this change to pom.xml:

diff --git a/pom.xml b/pom.xml
index 2ec017b..f2ab771 100644
--- a/pom.xml
+++ b/pom.xml
@@ -50,8 +50,8 @@
   </developers>
 
   <scm>
-    <connection>scm:git:https://github.com/${gitHubRepo}</connection>
-    <developerConnection>scm:git:https://github.com/${gitHubRepo}</developerConnection>
+    <connection>scm:git:git://github.com/${gitHubRepo}.git</connection>
+    <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>
     <url>https://github.com/${gitHubRepo}</url>
     <tag>${scmTag}</tag>
   </scm>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants