Fix getCurrentSpareInstanceCount - check busy nodes in given fleet, not whole Jenkins instance #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haugenj @imuqtadir Is there a possibility to kindly ask for a review please? |
|
@h-okon , thanks for both opening the issue and following up with a fix. I'll review this today.
Unfortunately (for us), those guys are no longer with the team |
brycahta
suggested changes
Aug 16, 2022
|
I have added a comment explaining the code |
brycahta
approved these changes
Aug 16, 2022
|
Can we have a new release after this one is merged? I think we observed the same and would love to apply the fix asap. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #342.
getCurrentSpareInstanceCount checks in whole Jenkins computers and does not account that we want to check only in given fleet.
I added a filter to filter worker nodes only from given fleet that is being checked. If we are not checking the computer from given fleet - we continue, we don't want to count the computer as busy computer in given fleet, because it is not a part of given fleet.