Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #322] Change the way executors are calculated to fix indefinite pending queue #367

Closed
wants to merge 2 commits into from

Conversation

mtn-boblloyd
Copy link

Change the way the executors are calculated by using the LoadStatisticsSnapshot rather than the strategyState object in Jenkins. This way, the number of executors is directly calculated by the available and connecting executors minus the busy executors, rather than considering ambiguous pending, and additionally planned executors, that can create availability that doesn't actually exist.

Testing done

Running this locally in our Jenkins instance for the last month without issue. No further testing was done.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@pdk27
Copy link
Collaborator

pdk27 commented Jun 1, 2023

@mtn-boblloyd Thanks for this PR, appreciate it.

A release with a fix for computations was just published. Here is the PR fix if you are interested in some context / details.
Here is the discussion thats open for further feedback on the release - #372.

Closing this PR for now. If you see unaddressed concerns, please leave a comment in the discussion or (re)open the related issue or open a PR.

@pdk27 pdk27 closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants