Fix cloud tracking #383
Merged
Fix cloud tracking #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tracking of cloud instance [refactor] Added instanceId to FleetNode for clarity, added getDescriptor to return sub type [refactor] Dont provision if Jenkins is quieting down and terminating Fix jenkinsci#360 Fix jenkinsci#322
cjerad
approved these changes
Jul 12, 2023
| @@ -4,16 +4,12 @@ | |||
| xmlns:t="/lib/hudson" xmlns:f="/lib/form" | |||
| xmlns:c="/lib/credentials"> | |||
|
|
|||
| <f:description>A unique name for this EC2 Fleet cloud</f:description> | |||
| <f:description>Warning: Cloud name is used to track agents belonging to this cloud. Please do not modify an existing cloud's name. See <a href="https://github.com/jenkinsci/ec2-fleet-plugin/issues/382">this issue</a> for details</f:description> | |||
There was a problem hiding this comment.
Is this warning the only barrier in place from changing the cloud name? What would happen to existing agents if a cloud name is changed?
There was a problem hiding this comment.
Unfortunately yes. I meant to create another task to implement disallowing name change. This PR is already handling a lot, so didn't want to overload it.
| @@ -338,13 +338,14 @@ public void should_continue_update_after_termination() throws IOException { | |||
| j.jenkins.getLabelAtom("momo").nodeProvisioner.suggestReviewNow(); | |||
| System.out.println("tasks submitted"); | |||
|
|
|||
| // wait full execution | |||
| // wait ful l execution | |||
There was a problem hiding this comment.
nit: spacing on the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jenkins Cloud represents user configuration and is bound to the corresponding user input data. i.e. a user-initiated change to the cloud configuration recreates that cloud's instance.
The plugin currently passes the cloud object around to Ec2FleetNode and Ec2FleetNodeComputer in an effort to link them to the cloud they belong to. This becomes problematic when those cloud instances are re-created. The plugin's re-assignment logic has been buggy requiring tracking of
oldIdetc.This PR removes the usage of
oldIdand cloud re-assignments and replaces cloud object tracking with tracking by name making cloud name a special configuration. Hence #382.Related issues:
Changes
Supporting changes:
Testing done
maxTotalUsesNow:
(Logs only used for development)
Before: