Print console log #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Aug 4, 2020
| } | ||
| catch (IllegalStateException | IOException e) { | ||
| //TODO: log to the build console | ||
| LOGGER.log(Level.WARN, "Could not publish GitHub check run", e); |
There was a problem hiding this comment.
still worth logging this to the system?
| Job<?, ?> job = context.getJob(); | ||
| Optional<GitHubSCMSource> source = scmFacade.findGitHubSCMSource(job); | ||
| if (!source.isPresent()) { | ||
| listener.getLogger().println("Failed creating GitHub checks publisher: no GitHub SCM source found."); |
There was a problem hiding this comment.
Suggested change
| listener.getLogger().println("Failed creating GitHub checks publisher: no GitHub SCM source found."); | |
| listener.getLogger().println("Skipped publishing GitHub checks: no GitHub SCM found."); |
| return Optional.empty(); | ||
| } | ||
|
|
||
| String credentialsId = source.get().getCredentialsId(); | ||
| if (credentialsId == null | ||
| || !scmFacade.findGitHubAppCredentials(job, credentialsId).isPresent()) { | ||
| listener.getLogger().println("Failed creating GitHub checks publisher: no GitHub APP credentials found."); |
There was a problem hiding this comment.
Suggested change
| listener.getLogger().println("Failed creating GitHub checks publisher: no GitHub APP credentials found."); | |
| listener.getLogger().println("Skipped publishing GitHub checks: no GitHub APP credentials found, see https://github.com/jenkinsci/github-branch-source-plugin/blob/master/docs/github-app.adoc"); |
| return Optional.empty(); | ||
| } | ||
|
|
||
| return Optional.of(new GitHubChecksPublisher(context)); | ||
| listener.getLogger().println("Using GitHub checks publisher."); |
There was a problem hiding this comment.
Suggested change
| listener.getLogger().println("Using GitHub checks publisher."); | |
| listener.getLogger().println("Publishing GitHub checks."); |
|
irrelevant CI failure |
timja
reviewed
Aug 4, 2020
| //TODO: log to the build console | ||
| LOGGER.log(Level.WARN, "Could not publish GitHub check run", e); | ||
| String message = "Failed Publishing GitHub checks: " + e; | ||
| LOGGER.log(Level.WARN, message); |
There was a problem hiding this comment.
always log the exception with the throwable arg
Suggested change
| LOGGER.log(Level.WARN, message); | |
| LOGGER.log(Level.WARN, message, e); |
timja
reviewed
Aug 4, 2020
| LOGGER.log(Level.WARN, "Could not publish GitHub check run", e); | ||
| String message = "Failed Publishing GitHub checks: " + e; | ||
| LOGGER.log(Level.WARN, message); | ||
| listener.getLogger().println(message); |
There was a problem hiding this comment.
Suggested change
| listener.getLogger().println(message); | |
| listener.getLogger().println(message + e); |
timja
reviewed
Aug 4, 2020
| } | ||
| catch (IllegalStateException | IOException e) { | ||
| //TODO: log to the build console | ||
| LOGGER.log(Level.WARN, "Could not publish GitHub check run", e); | ||
| String message = "Failed Publishing GitHub checks: " + e; |
There was a problem hiding this comment.
Suggested change
| String message = "Failed Publishing GitHub checks: " + e; | |
| String message = "Failed Publishing GitHub checks: "; |
timja
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use TaskListener to print console log