Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release drafter configuration #3

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Add release drafter configuration #3

merged 2 commits into from
Jul 6, 2020

Conversation

timja
Copy link
Member

@timja timja commented Jul 6, 2020

No description provided.

@timja timja requested a review from XiongKezhi July 6, 2020 11:04
Copy link
Contributor

@XiongKezhi XiongKezhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a little confused by the release-drafter

Does it automatically create a release PR after all other PRs are merged? The releasing will be done once after we merged that release PR?

@@ -0,0 +1,2 @@
_extends: .github
tag-template: github-checks-$NEXT_MINOR_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may change the template in the final stage.

@XiongKezhi
Copy link
Contributor

I'm still a little confused by the release-drafter

Does it automatically create a release PR after all other PRs are merged? The releasing will be done once after we merged that release PR?

No such release PR... I think I can find the answer here: https://www.youtube.com/watch?v=lphs-7s4NtQ

@timja
Copy link
Member Author

timja commented Jul 6, 2020

It updates the release notes based off PR title and labels

@timja timja added the chore label Jul 6, 2020
@timja timja merged commit 0f7bc5a into master Jul 6, 2020
@timja timja deleted the timja-patch-2 branch July 6, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants