Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of analysis-pom to 4.1.0 (and codingstyle to 1.4.0) #35

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Aug 24, 2020

Replace Nullable with CheckForNull: CheckForNull is now supported by NullAway as well.

Replace `Nullable` with `CheckForNull`: `CheckForNull` is now supported by NullAway as well.
@uhafner uhafner requested a review from a team as a code owner August 24, 2020 21:56
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #35 into master will increase coverage by 37.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #35       +/-   ##
=============================================
+ Coverage     37.66%   75.33%   +37.66%     
- Complexity       58       94       +36     
=============================================
  Files             7        7               
  Lines           300      300               
  Branches         32       32               
=============================================
+ Hits            113      226      +113     
+ Misses          176       52      -124     
- Partials         11       22       +11     
Impacted Files Coverage Δ Complexity Δ
...s/plugins/checks/github/GitHubChecksPublisher.java 90.90% <ø> (+66.66%) 5.00 <0.00> (+2.00)
...ns/checks/github/GitHubSCMSourceChecksContext.java 89.47% <ø> (ø) 15.00 <0.00> (ø)
...ins/plugins/checks/github/GitSCMChecksContext.java 53.48% <ø> (+41.86%) 14.00 <0.00> (+12.00)
...va/io/jenkins/plugins/checks/github/SCMFacade.java 61.36% <ø> (+43.18%) 15.00 <0.00> (+8.00)
...ins/plugins/checks/github/GitHubChecksContext.java 100.00% <100.00%> (ø) 14.00 <1.00> (ø)
...ns/checks/github/GitHubChecksPublisherFactory.java 90.47% <0.00%> (+19.04%) 11.00% <0.00%> (+3.00%)
...ins/plugins/checks/github/GitHubChecksDetails.java 70.21% <0.00%> (+53.19%) 20.00% <0.00%> (+11.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ab753...7b151f3. Read the comment docs.

@XiongKezhi XiongKezhi merged commit 37de36b into master Aug 25, 2020
@XiongKezhi XiongKezhi deleted the codingstyle-1.4.0 branch August 25, 2020 03:39
@XiongKezhi XiongKezhi added the dependencies Pull requests that update a dependency file label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants