Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SKIPPED conclusion, use CANCELLED instead #64

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Remove SKIPPED conclusion, use CANCELLED instead #64

merged 1 commit into from
Oct 14, 2020

Conversation

XiongKezhi
Copy link
Contributor

@XiongKezhi XiongKezhi commented Oct 13, 2020 •
edited by timja
Loading

Fixes #63

@XiongKezhi XiongKezhi added the bug Something isn't working label Oct 13, 2020
@XiongKezhi XiongKezhi requested a review from timja October 13, 2020 11:51
@XiongKezhi XiongKezhi requested a review from a team as a code owner October 13, 2020 11:51
@XiongKezhi XiongKezhi self-assigned this Oct 13, 2020
@XiongKezhi XiongKezhi linked an issue Oct 13, 2020 that may be closed by this pull request
Failed Publishing GitHub checks - Invalid request. skipped is not a member of ... #63
Closed
timja
timja approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @daniel-beck

@codecov
Copy link

codecov bot commented Oct 13, 2020 •
edited
Loading

Codecov Report

Merging #64 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     79.47%   79.70%   +0.23%     
  Complexity      106      106              
============================================
  Files             8        8              
  Lines           341      340       -1     
  Branches         35       35              
============================================
  Hits            271      271              
+ Misses           50       49       -1     
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...ins/plugins/checks/github/GitHubChecksDetails.java 70.96% <ø> (+0.75%) 20.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998f6db...13cd73f. Read the comment docs.

@XiongKezhi XiongKezhi merged commit 6ff90f9 into master Oct 14, 2020
@XiongKezhi XiongKezhi deleted the avoid-using-skipped-conclusion branch October 14, 2020 02:04
@beikov beikov mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees

@XiongKezhi XiongKezhi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed Publishing GitHub checks - Invalid request. skipped is not a member of ...
2 participants
@XiongKezhi @timja