Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed logging on publish #68

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Conversation

timja
Copy link
Member

@timja timja commented Oct 22, 2020

Hopefully will help with:

image

I'm also hitting it in production, a lot of checks aren't getting published, but logs all seem fine

@timja timja requested a review from a team as a code owner October 22, 2020 07:31
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #68 into master will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     79.30%   79.65%   +0.35%     
  Complexity      106      106              
============================================
  Files             8        8              
  Lines           343      349       +6     
  Branches         36       36              
============================================
+ Hits            272      278       +6     
  Misses           50       50              
  Partials         21       21              
Impacted Files Coverage Δ Complexity Δ
...s/plugins/checks/github/GitHubChecksPublisher.java 97.36% <100.00%> (+0.49%) 5.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e43bc...6cd1cf3. Read the comment docs.

@timja timja merged commit db5fd67 into jenkinsci:master Oct 23, 2020
@timja timja deleted the add-logging branch October 23, 2020 08:51
@timja timja added the enhancement New feature or request label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants