Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment author to CauseData for Note events #1372

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

irth
Copy link
Contributor

@irth irth commented Dec 7, 2022

Builds triggered by comments do not have information about who made the comment. For my use case, I needed this information to be available to the Jenkins job.

This pull requests adds a $gitlabCommentAuthor (if there is one) to the build environment for Note events.

@irth irth requested a review from a team as a code owner December 7, 2022 18:23
@kinglezhuang
Copy link

Can you add the comment author email too?

@krisstern
Copy link
Member

Can you add the comment author email too?

Or we could create a new issue for adding author email...

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Thanks @irth!

@krisstern krisstern merged commit ef3356d into jenkinsci:master Jan 31, 2023
@irth irth deleted the commentAuthor branch February 19, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants