Use upstream Spotless configuration #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Jenkins Security Scan found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
The security scan issues are false positives, since those issues existed before this PR as well. It is just noticing them because the files are newly formatted and line numbers have changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the Spotless configuration from jenkinsci/plugin-pom#733 to this repository and formats the entire repository by running
mvn spotless:apply. See that PR for a description of the changes and their motivation. Since formatting is a subjective matter, the choice is up to the maintainers about whether or not they wish to opt in. I would not be upset if the maintainers choose not to accept this PR. If accepted, the next steps after merging this PR would be to add a.git-blame-ignore-revsfile so that this commit does not show up in Git blame.