Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support folders and duplicate names #12

Merged
merged 3 commits into from
Mar 2, 2017

Conversation

willemvd
Copy link
Contributor

use Jenkins.getItemByFullName to search for a job so we can support folder structures and duplicate names inside folders, for backward compatibility we also search through all items when not found (old behaviour)

This will make it easy to find items in folders like in #10

…ructures and duplicate names inside folders, for backward compatibility we also search through all items when not found (old behaviour)
* prevent private fields and possible threading issues
@sanderv32
Copy link
Contributor

Thanks Willem. Can i merge this without breaking the plugin?

Copy link
Contributor

@sanderv32 sanderv32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, will approve this.

Copy link
Contributor

@sanderv32 sanderv32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@willemvd
Copy link
Contributor Author

willemvd commented Mar 2, 2017

Yes I have created it in a way that it is backwards compatible

@sanderv32 sanderv32 merged commit d0fb276 into jenkinsci:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants