Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FindBugs issue #115

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

nigelarmstrong-bc
Copy link
Contributor

@nigelarmstrong-bc nigelarmstrong-bc commented Mar 15, 2021

FindBugs doesn't recognize Objects.requireNonNull as checking null. Saw this on the development branch builds

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

FindBugs doesn't recognize `Objects.requireNonNull` as checking null
@asimell
Copy link
Contributor

asimell commented Mar 16, 2021

LGTM

@asimell asimell merged commit 517a831 into jenkinsci:development Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants