updated getSonarProjectFromBuildReport to handle analysis URL that is… #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provided by sonarqube 9.3 which includes /dashboard?id=.." in the URL
5 tasks
|
Hello @cburne-oshyn, sorry for my late response. I was a busy with other stuffs. So, for 8.9 LTS release, the build log also looks like as follows: 12:14:49 INFO: ANALYSIS SUCCESSFUL, you can browse https://prod.sonarqube.blahblah.net/dashboard?id=63e375e6-0b19-4b9e-87d0-218a629fda9c&branch=develop
12:14:49 INFO: Note that you will be able to access the updated dashboard once the server has processed the submitted analysis report
12:14:49 INFO: More about the report processing at https://prod.sonarqube.blahblah.net/api/ce/task?id=AX94Ql3Pr0yhtSb6a_cC
12:14:50 INFO: Analysis total time: 32.529 sWhich it's the same with yours. Right? I am not getting this issue, because I have set the So, I believe that, below snippet should fix this issue: url = match.group(1); // url = "https://prod.sonarqube.blahblah.net/dashboard?id=63e375e6-0b19-4b9e-87d0-218a629fda9c&branch=develop"
url = url.substring(0,url.lastIndexOf(('/'))); // url = "https://prod.sonarqube.blahblah.net" |
kumbasar
reviewed
Mar 14, 2022
| @@ -302,6 +302,10 @@ protected String getResult(String url) throws IOException { | |||
| match = p_analysis_url.matcher(line); | |||
| if (match.matches()) { | |||
| url = match.group(1); | |||
| long count = url.chars().filter(ch -> ch == '/').count(); | |||
There was a problem hiding this comment.
below should be fine
url = match.group(1); // url = "https://prod.sonarqube.blahblah.net/dashboard?id=63e375e6-0b19-4b9e-87d0-218a629fda9c&branch=develop"
url = url.substring(0,url.lastIndexOf(('/'))); // url = "https://prod.sonarqube.blahblah.net"
|
Hi @cburne-oshyn @kumbasar , I know this has been hanging for quite a while already. I'm currently increasing the overall unit test coverage for the whole plugin and I stumbled on this same bug and fixed it with d6bd919. I'll soon merge these unit tests/bug fixes into the main branch, so I will close this in favour of that PR. I did implement the fix based on this PR, so thanks for opening this 🙏 |
|
Ha! Good deal! That's great to hear. I'm still using the plugin successfully and am thankful for your maintenance of it all these years.
CHRISTIAN BURNE
…-------- Original message --------
From: Aleksi Simell ***@***.***>
Date: 2/14/24 10:51 PM (GMT-08:00)
To: jenkinsci/influxdb-plugin ***@***.***>
Cc: Christian Burne ***@***.***>, Mention ***@***.***>
Subject: Re: [jenkinsci/influxdb-plugin] updated getSonarProjectFromBuildReport to handle analysis URL that is… (PR #131)
Hi @cburne-oshyn<https://github.com/cburne-oshyn> @kumbasar<https://github.com/kumbasar> ,
I know this has been hanging for quite a while already. I'm currently increasing the overall unit test coverage for the whole plugin and I stumbled on this same bug and fixed it with d6bd919<d6bd919>. I'll soon merge these unit tests/bug fixes into the main branch, so I will close this in favour of that PR. I did implement the fix based on this PR, so thanks for opening this 🙏
—
Reply to this email directly, view it on GitHub<#131 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS43J7EQ4GX23NYY46HNQ33YTWV7ZAVCNFSM5P76HVGKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJUGU2DMNJWGA4Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… provided by sonarqube 9.3 which includes /dashboard?id=.." in the URL
Sonarqube Analysis url from Sonarqube 9.3 in the build log has the following structure:
INFO: ANALYSIS SUCCESSFUL, you can browse https://sonarqube.xxx.com/dashboard?id=XXX.Web
The current logic just appends the api call after the "/dashboard?id=XXX.Web". This new logic checks to see if there are three "/" chars in the url and if there are, it grabs the url prior to the 3rd "/". It should not touch the URL if there are only 2 slashes as in "https://sonarqube.xyz.com" (although I am unable to test this, I'm hoping @kumbasar can check this for me in his installation).
Re-add getting sonar project parameters from build log feature #129