Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Java implementation to list available icons #16

Merged
merged 3 commits into from
Sep 24, 2022
Merged

Provide Java implementation to list available icons #16

merged 3 commits into from
Sep 24, 2022

Conversation

strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Sep 21, 2022 •
edited by NotMyFault
Loading

Fixes #14

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner September 21, 2022 11:21
@NotMyFault NotMyFault added the enhancement New feature or request label Sep 22, 2022
NotMyFault
NotMyFault reviewed Sep 22, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

could you change the folder structure to io.jenkins.plugins, please? This format matches the GAV format this plugin uses.

NotMyFault
NotMyFault approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@NotMyFault NotMyFault merged commit bcd49d6 into jenkinsci:main Sep 24, 2022
@strangelookingnerd strangelookingnerd mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide Java implementation to list available icons
2 participants
@strangelookingnerd @NotMyFault