Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons to be themeable #47

Merged
merged 1 commit into from
May 22, 2023
Merged

Update icons to be themeable #47

merged 1 commit into from
May 22, 2023

Conversation

strangelookingnerd
Copy link
Contributor

Follow-up to #20 since there were some icons that I have missed and some new ones have been added.

Testing done

Manual testing, but my eyes are getting a little dizzy since it is sometimes very hard to identify if something is wrong 😵

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner May 22, 2023 13:07
@NotMyFault NotMyFault added the bug Something isn't working label May 22, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault merged commit 1b1c8c4 into jenkinsci:main May 22, 2023
@strangelookingnerd strangelookingnerd deleted the fix_icon_theming branch May 22, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants