This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
JENKINS-49823 - Ignore non existing class directory #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In hudson/plugins/jacoco/JacocoBuildAction.java:342 there is no check for null done currently, so we would run into a NullPointerException there, or? Can you guard against this there as well? See the new test in the branch at https://github.com/jenkinsci/jacoco-plugin/tree/michbeck100-JENKINS-49823 for a reproducer. |
|
I tested this PR out and it appears to fix the issue i'm having in a multibranch pipeline project that had upgraded to 3.0.1 |
centic9
added a commit
that referenced
this pull request
Sep 19, 2018
Fix possible NullPointerException introduced via PR #100
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a Jenkins pipeline for multiple projects, there might not always be a classes directory (e.g. on pom-only projects). This PR ignores non-existing class directories.