This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Remove obsolete maven-enforcer ASM exclude #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't overwrite phase, goals and excludes but just extend the excludes. For more details see https://github.com/jenkinsci/plugin-pom/blob/plugin-3.50/pom.xml#L573-L590. Note: This change is only performed to have an improved example for potential future configurations. This configuration is currently not required and will be removed with the next commit.
It was originally introduced because the ASM jar files contain a module-info.class which is targeted to Java 9. When using JDK 8 for building the enforcer therefore complained. The current parent pom uses the newer extra-enforcer-rules 1.2 which ignores the module-info.class in case a JDK < 9 is used. For more details see - mojohaus/extra-enforcer-rules#33 - mojohaus/extra-enforcer-rules#46
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally introduced because the ASM jar files contain a module-info.class which is targeted to Java 9. When using JDK 8 for building the enforcer therefore complained.
The current parent pom uses the newer extra-enforcer-rules 1.2 which ignores the module-info.class in case a JDK < 9 is used.
For more details see