Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

JENKINS-26254 Use BufferedInputStream to read .exec files #78

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

seanf
Copy link
Member

@seanf seanf commented Dec 3, 2016

https://issues.jenkins-ci.org/browse/JENKINS-26254

It doesn't seem to make much difference in an unloaded server, but hopefully it will speed up the post-build steps when Jenkins is under load.

EDIT: I've built a copy of the plugin here, if you want to risk it:
jacoco-plugin.zip

@seanf
Copy link
Member Author

seanf commented Dec 3, 2016

By the way, CoverageObjectGraphTest doesn't pass on Fedora 24, although it's okay on Windows 10. It looked like there were some minor rendering differences in the fonts when running on Fedora. Perhaps caused by the lack of subpixel rendering?

I had an SVG-based test all set, but then the SVG wasn't consistent between Fedora and Windows either. :-(

@centic9 centic9 merged commit a35ce73 into jenkinsci:master Dec 3, 2016
@centic9
Copy link
Member

centic9 commented Dec 3, 2016

Thanks for the patch, I'll take a look at the test to see if anything can be done about it.

@seanf seanf deleted the JENKINS-26254-use-buffer branch December 4, 2016 00:53
@centic9
Copy link
Member

centic9 commented Dec 4, 2016

BTW, I could not see why the test fails, maybe you can create a separate issue and attach any error-output/details so the original author of the test can take a look?

@seanf
Copy link
Member Author

seanf commented Dec 7, 2016

Thanks @centic9. I've submitted https://issues.jenkins-ci.org/browse/JENKINS-26254.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants