Provide Hamcrest matchers as alternatives to built-in JenkinsRule run assertions #878
Conversation
Plays nicely with Awaitability as well as in combination with other matchers.
Vlatombe
changed the title
| } | ||
| } | ||
|
|
||
| private static class RunLogMatcher extends TypeSafeMatcher<Run<?, ?>> { |
There was a problem hiding this comment.
What about waitForMessage? This has special behavior for a completed build; not sure if that can be carried over to Awaitility.
There was a problem hiding this comment.
It has a fail-early mechanism in case a build is complete, but I don't see how to replicate that using Awaitibility and matchers.
There was a problem hiding this comment.
I guess something like
await().until(b, completed());
assertThat(b, logContains("foo"));
would be equivalent to the current waitForMessage
There was a problem hiding this comment.
No, because waitForMessage can be used to wait for a line in a running build.
I was just wondering if there was something in Awaitility that a matcher can use to indicate that not only does the condition not match now, we can be sure it will not match later. https://javadoc.io/static/org.awaitility/awaitility/4.2.2/org/awaitility/core/FailFastCondition.html maybe? No Javadoc 😢
There was a problem hiding this comment.
There was a problem hiding this comment.
So something like
await().failFast(() -> !b.isLogUpdated()).until(() -> b, logContains("foo"));
?
There was a problem hiding this comment.
No, that forces the tricky logic to be put into the call site, and only works for a message which you expect to be printed in a running build. I was hoping for something that could be built into the harness that would provide the same functionality as waitForMessage but integrated into Awaitility: pass if the message appears; fail immediately if the build terminates without the message ever appearing.
| private static class CompletedRunMatcher extends TypeSafeMatcher<Run<?, ?>> { | ||
| @Override | ||
| protected boolean matchesSafely(Run<?, ?> run) { | ||
| return !run.isLogUpdated(); |
There was a problem hiding this comment.
So I think
could be deleted and that method could also suggest using this matcher.
|
Relaunching CI |
Plays nicely with Awaitability as well as in combination with other matchers.
Testing done
Submitter checklist