Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39414] Integrating Stapler 1.248 #2622

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 7, 2016

Changes are just jenkinsci/stapler#88.

@reviewbybees esp. @oleg-nenashev

@ghost
Copy link

ghost commented Nov 7, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev
Copy link
Member

🐝 as an author of jenkinsci/stapler#88
We should finally start doing changelogs in Stapler...

@jglick jglick added the needs-more-reviews Complex change, which would benefit from more eyes label Nov 7, 2016
@oleg-nenashev
Copy link
Member

@jenkinsci/code-reviewers It would be great to get the review. We want to merge it into the tomorrow's out-of-order release (discussion)

@abayer
Copy link
Member

abayer commented Nov 7, 2016

🐝

@oleg-nenashev
Copy link
Member

@reviewbybees done

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Nov 7, 2016
@christ66
Copy link
Member

christ66 commented Nov 7, 2016

🐝

@ghost
Copy link

ghost commented Nov 7, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@oleg-nenashev oleg-nenashev merged commit 5aed788 into jenkinsci:master Nov 7, 2016
oleg-nenashev added a commit that referenced this pull request Nov 7, 2016
oleg-nenashev added a commit that referenced this pull request Nov 7, 2016
@jglick jglick deleted the stapler-1.248 branch November 7, 2016 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants