Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove All localized files of Chinese #4008

Merged
merged 1 commit into from
May 4, 2019

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented May 2, 2019

All related plugins are published. Below are PRs:

jenkinsci/localization-zh-cn-plugin#31
jenkinsci/localization-support-plugin#1
jenkinsci/localization-zh-cn-plugin#71

Proposed changelog entries

  • Entry 1: Localization, Remove and migrate all Chinese localization files into localizationi-zh-cn plugin

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go forward with the merge?
CC @daniel-beck who was involved in JEP-216

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 3, 2019
@oleg-nenashev
Copy link
Member

Will merge it tomorrow if there is no negative feedback

@daniel-beck
Copy link
Member

localization-zh-cn now depends on the newly released localization-support that should add full support for all of this.

Would get confirmation from @LinuxSuRen that the PR build with the plugins installed retain all localizations removed here, and if so, proceed.

Copy link
Contributor

@MRamonLeon MRamonLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if @LinuxSuRen confirms what @daniel-beck is asking.

@LinuxSuRen
Copy link
Member Author

Sorry about the delay. Time difference.
@daniel-beck @MRamonLeon Yes, localization-zh-cn already contains those files. Please go ahead.

@oleg-nenashev oleg-nenashev merged commit 4ea5d14 into jenkinsci:master May 4, 2019
@LinuxSuRen LinuxSuRen deleted the remove-all-zh-files branch May 5, 2019 00:09
@mamh2021
Copy link
Contributor

@LinuxSuRen 你这个比较坑阿。一不小心升级一下,发现没本地中文翻译了阿。后来查到你这个提交才知道要安装的插件。

@LinuxSuRen
Copy link
Member Author

@mmh891113 您好,首先对给您的不方便表示歉意。不过,我们的这次变更是有在社区的邮件列表里讨论过的。另外,在版本发布的变更记录也有说明,同时,也在官方的微信公众号里也有公布。
为了能够避免类似的情况,可以关注我们的官方的媒体渠道。
谢谢您的理解和支持。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants