[JENKINS-64035] - Winstone 5.12: Update Jetty from 9.4.30.v20200611 to 9.4.33.v20201020 #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 9.4.33.v20201020
oleg-nenashev
added
the
rfe
|
@jenkinsci/core I suggest an expedited merge of this pull request into 2.264. It would help us to collect more community feedback and decide whether the new Jetty release can be [threoretically] backported into 2.263.1 |
daniel-beck
approved these changes
Oct 26, 2020
res0nance
approved these changes
Oct 26, 2020
oleg-nenashev
added
the
ready-for-merge
|
We may merge it tomorrow at 9AM UTC if there is no negative feedback. Please see the merge process documentation for more information about the merge process |
timja
approved these changes
Oct 26, 2020
I suggest just merging after CI is green... |
|
OK, taking the feedback. 🚢 🇮🇹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 9.4.33.v20201020 Jetty version picks up an upstream fix for jetty/jetty.project#5417 which caused JENKINS-63958 in Jenkins 2.261 and was worked around by downgrading Jetty in Winstone 5.11.1 and Jenkins 2.263. It would be great to include the new version into the weekly release, and then, maybe, consider it for backporting to 2.263.x LTS if the community ratings are fine.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).