Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Util#join(Collection, String) in favor of String#join(CharSequence, Iterable) #5467

Merged
merged 1 commit into from
May 9, 2021

Conversation

basil
Copy link
Member

@basil basil commented May 7, 2021

String#join(CharSequence, Iterable) was introduced in Java 8, making our own Util#join(Collection, String) redundant.

@basil basil requested a review from jtnord May 7, 2021 16:53
@basil basil added the skip-changelog Should not be shown in the changelog label May 7, 2021
@res0nance res0nance added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 8, 2021
@res0nance
Copy link
Contributor

This change is considered ready to merge we may merge in 24 hours if there is no negative feedback

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants