Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Groovy files in root Maven module with Spotless #7834

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 11, 2023

This PR formats Jenkinsfile and licenseCompleter.groovy, using a common Groovy configuration from the new shared-resources artifact. While the primary motivation behind this change is to make these files easier to read, the secondary motivation is that I intend to do some work on the Jenkinsfile in this repository soon, and since there is no compiler for that code it is helpful to have at least an AST parser to check over syntax before trying to run the code on a real Jenkins server.

Testing done

Ran mvn clean verify -DskipTests.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the skip-changelog Should not be shown in the changelog label Apr 11, 2023
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 18, 2023
@basil
Copy link
Member Author

basil commented Apr 18, 2023

Thanks for starting the merge process Alex. Since I have another PR that builds on top of this one and since this PR is fairly minor, I am going to expedite this change a little early so that I can make progress more quickly on the next PR that depends on this one without dealing with merge conflicts.

@basil basil merged commit a211c62 into jenkinsci:master Apr 18, 2023
@basil basil deleted the spotless branch April 18, 2023 23:10
@MarkEWaite
Copy link
Contributor

Caused JENKINS-71147 - cannot compile Jenkins core on aarch64 Linux, s390x Linux. Likely cannot compile core on ppc64le also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants