Basic ProxyConfigurationManagerTest
#8952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across #8693 and noticed that the XML serial form of
ProxyConfiguration
was not tested. This is not trivial as can be seen fromjenkins/core/src/main/java/hudson/ProxyConfiguration.java
Lines 296 to 306 in 8b94924
jenkins/core/src/main/java/hudson/ProxyConfiguration.java
Lines 506 to 512 in 8b94924
(There is also a getter & setter in
Jenkins
from #3935 which is tested downstream inconfiguration-as-code-plugin
:ProxyConfiguratorTest
.)Testing done
Test passes locally.
Proposed changelog entries
Before the changes are marked as
ready-for-merge
:Maintainer checklist