Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73668] fix styling of rowSelectionController dropdown #9641

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Aug 21, 2024

Ensure that it looks the same as before #9131

Before:
image

After:
image

See JENKINS-73668.

Testing done

Manual testing

Proposed changelog entries

  • Fix the appearance of the Plugin Manager actions dropdown.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

ensure there is enough gap between entries
@mawinter69 mawinter69 marked this pull request as draft August 21, 2024 19:20
@mawinter69 mawinter69 marked this pull request as ready for review August 21, 2024 20:39
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 21, 2024
@timja timja added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Aug 21, 2024
@NotMyFault NotMyFault merged commit de5cd41 into jenkinsci:master Aug 24, 2024
16 checks passed
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Sep 16, 2024
…nsci#9641)

* [JENKINS-73668] fix stlying of rowSelectionController dropdown

ensure there is enough gap between entries

* style it as before with smaller dropdown button

* apply prettier

(cherry picked from commit de5cd41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants