Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monochrome symbol for directory tree #1477

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Oct 16, 2024

Before

before

After

(default)
default

(dark)
dark

Testing done

Only checking visual

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner October 16, 2024 12:19
@basil
Copy link
Member

basil commented Oct 17, 2024

I don't mind approving this if necessary, but I must admit that the new image looks worse than the original one to me. The original one is very clearly a folder with subfolders. I'm not sure what the second image represents. It looks more like the pins of a microprocessor to me and it is not obviously a folder/subfolders at all.

@jonesbusy
Copy link
Contributor Author

I will try to do an other proposal

@jonesbusy
Copy link
Contributor Author

Does it look more like subdirectories now ?

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 1090a3b into jenkinsci:master Oct 30, 2024
17 checks passed
@jonesbusy jonesbusy deleted the feature/mono-chrome-symbol branch October 30, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants