Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim stdio even on failing tests, just to a 100× larger cutoff #12

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 16, 2015

When !keepLongStdio, the stdout/stderr of passing tests is truncated to avoid memory pressure, under the assumption that you probably do not care about the details much. This is good, but it is useful to have some kind of limit even for failing tests. Otherwise a test that produces copious log output, then fails, can overwhelm the remoting channel and the Jenkins master heap. This patch sets the limit to be around 100K per incident (in JUnit, that means per test suite).

@reviewbybees (ref. ZD-24570)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@tfennelly
Copy link
Member

👍

Perhaps those possiblyTrimStdio methods could be dried out a bit, both delegating the reading of the head and tail to a version that takes a TextReader version of TextFile. Just a thought.

@recampbell
Copy link
Member

👍

@jglick
Copy link
Member Author

jglick commented Feb 19, 2015

Perhaps those possiblyTrimStdio methods could be dried out a bit

Perhaps. I am reluctant to really change the implementation of these, since my original implementation apparently did not work as it was supposed to at all and @kohsuke had to fix it, but the problem (excess disk I/O) is difficult or impossible to test.

jglick added a commit that referenced this pull request Feb 23, 2015
Trim stdio even on failing tests, just to a 100× larger cutoff
@jglick jglick merged commit 5f7513b into jenkinsci:master Feb 23, 2015
@jglick jglick deleted the trim-stdio-even-on-fail branch February 23, 2015 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants