Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26077] Duplicated TestResultProjectAction #18

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 29, 2015

JENKINS-26077

@reviewbybees

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@@ -86,8 +88,14 @@ public TestResultAction(TestResult result, BuildListener listener) {
this((Run) null, result, listener);
}

@SuppressWarnings("deprecation")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really make sense to filter away deprecations? It would be better to leave them as warnings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to Job.getActions() cannot be avoided here. Normally it should not be used, but this is one of the exceptions.

@oleg-nenashev
Copy link
Member

👍

jglick added a commit that referenced this pull request May 1, 2015
…-JENKINS-26077

[JENKINS-26077] Duplicated TestResultProjectAction
@jglick jglick merged commit 49139a4 into jenkinsci:master May 1, 2015
@jglick jglick deleted the duplicated-TestResultProjectAction-JENKINS-26077 branch May 1, 2015 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants