Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69657] Un-inlining floatingBox.jelly for CSP compliance #445

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Oct 8, 2022

Hello 👋

Here's another Hacktoberfest Pull Request to solve JENKINS-69657, by un-inlining floatingBox.jelly, and then making a step forward towards CSP adoption in Jenkins.

Before submitting the PR, I tested the existing code, removed the script to show that my test was not working anymore, un-inlined the test and checked that I worked again. Here it is working with the script un-inlined (which is similar to the behavior before the PR):

junit-switch-color

Thanks a lot for your review, let me know if there's anything missing I can take care of 😄

Have a great day!

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit c4c2e37 into jenkinsci:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants