Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow node ID to external storage API #622

Closed
wants to merge 1 commit into from

Conversation

timja
Copy link
Member

@timja timja commented Jun 15, 2024

This is currently a breaking change although it could likely be made more compatible.
There's only realtime junit to adapt anyway.

I'm not sure this is the best approach and would appreciate any guidance.

See https://github.com/jenkinsci/junit-sql-storage-plugin/pull/414/files#diff-1202c93b95ce3f5252dc25bf1a5ab73d75ebc67052d675c97d5e146a3448596aR140

In order to link the traces that are being used for instrumenting the junit sql plugin I need access to the FlowNodeMonitoringAction to get the open telemetry trace parent id.

That is attached to the flow node and I couldn't find a way other than passing it down to get to it.
The normal Context.current from otel doesn't work as the otel plugin uses actions for tracking and isn't able to setup block scopes and pass it along.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick
Copy link
Member

jglick commented Jul 8, 2024

I need access to the FlowNodeMonitoringAction to get the open telemetry trace parent id.

Sorry, I am not familiar with this is.

The diff looks reasonable, though as you noted it could be made binary compatible which might ease rollout.

@timja
Copy link
Member Author

timja commented Aug 14, 2024

not needed anymore

@timja timja closed this Aug 14, 2024
@timja timja deleted the add-flow-node-id branch August 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants