Add flow node ID to external storage API #622
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a breaking change although it could likely be made more compatible.
There's only realtime junit to adapt anyway.
I'm not sure this is the best approach and would appreciate any guidance.
See https://github.com/jenkinsci/junit-sql-storage-plugin/pull/414/files#diff-1202c93b95ce3f5252dc25bf1a5ab73d75ebc67052d675c97d5e146a3448596aR140
In order to link the traces that are being used for instrumenting the junit sql plugin I need access to the
FlowNodeMonitoringAction
to get the open telemetry trace parent id.That is attached to the flow node and I couldn't find a way other than passing it down to get to it.
The normal
Context.current
from otel doesn't work as the otel plugin uses actions for tracking and isn't able to setup block scopes and pass it along.Testing done
Submitter checklist