Update SDK, fix cert validation, and default radio button #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the SDK to 16.2.1. This fixes a problem where notation would not find the field if a label was used. The certificate validation button would always return an error. This was due to the hostname entry box being below the validation button. When passing values it would not include the hostname. Move the hostname entry box above the validation button. When adding a new secret, no default radio button is checked. Changed the code so the a new secret would default to the Env checbox. Updated the README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the SDK to 16.2.1. This fixes a problem where notation would
not find the field if a label was used.
The certificate validation button would always return an error. This
was due to the hostname entry box being below the validation button.
When passing values it would not include the hostname. Move the
hostname entry box above the validation button.
When adding a new secret, no default radio button is checked. Changed
the code so the a new secret would default to the Env checbox.
Updated the README.md