Update the Keeper Secrets Manager SDK #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KSM server is returning appData in the JSON response. The JSON parser doesn't like the extra key in the JSON and throws an exception. Update the SDK to accept the new key in JSON. Updated Kotlin deps for new SDK. Added more debug around calls to KSM server to see the timing of the calls. There appears to be an issue where calls to the KSM server are taking a long time to complete. This at reason show when the call was started and finished. Changed the plgins getSecrets to getNotationSecrets to be less ambiguous with the SDK's getSecrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KSM server is returning appData in the JSON response. The JSON
parser doesn't like the extra key in the JSON and throws an
exception. Update the SDK to accept the new key in JSON.
Updated Kotlin deps for new SDK.
Added more debug around calls to KSM server to see the timing of
the calls. There appears to be an issue where calls to the KSM
server are taking a long time to complete. This at reason show
when the call was started and finished.
Changed the plgins getSecrets to getNotationSecrets to be less
ambiguous with the SDK's getSecrets.