-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh plugin #11
Refresh plugin #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let me see if I can cut a release without tricks…
<configuration> | ||
<useReleaseProfile>false</useReleaseProfile> | ||
<releaseProfiles>cloudbees-release</releaseProfiles> | ||
</configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we could add anything needed (like GPG signing) to the standard release
profile, but this is fine too.
|
||
<profiles> | ||
<profile> | ||
<id>jdk-8-and-below</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we still need this—can assume that releases run on 11 (or newer).
*/ | ||
@Mojo(name = "process", requiresDependencyResolution = ResolutionScope.RUNTIME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nope:
Probably things that came from the parent. I will try to fix. |
Also updating `name`, `url`, & `scm` while I am here.
After some trial & error, managed to get https://github.com/cloudbees/maven-license-plugin/releases/tag/maven-license-plugin-1.15 released. https://gist.github.com/jglick/b4ece94b38f139a66d3333f7cc925099 FTR |
…maven-plugin#11 [ERROR] Failed to execute goal com.cloudbees:maven-license-plugin:1.15:process (default) on project jenkins-war: Execution default of goal com.cloudbees:maven-license-plugin:1.15:process failed: No signature of method: org.apache.maven.project.DefaultProjectBuilder.buildFromRepository() is applicable for argument types: (org.apache.maven.artifact.DefaultArtifact, ArrayList, org.apache.maven.artifact.repository.MavenArtifactRepository)
Updates all dependencies to the latest version, including adapting to recent Maven plugin API changes. Since Kohsuke's parent POM is no longer maintained and the Jenkins parent POM publishes to the Jenkins Artifactory rather than Maven Central, I have chosen to remove any parent POM from this project. While this does entail a little duplication, it simplifies the management of this non-standard component by only pulling in exactly what we need. The ugliness of a solution that duplicates the code merely mirrors the ugliness of the deployment setup and GitHub organization of this repository, which does not follow our standard conventions.
Testing done
I ensured that Javadocs could be built by running (locally)
mvn clean verify -Pcloudbees-release -Dgpg.skip
on both Java 8 and Java 11.I tested this on Java 19 with a Jenkins core build and verified that the generated license information was the same before and after this PR. Note that to adapt to Maven API changes the core build needed this patch:
CC @jglick