Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CD #25

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Enable CD #25

merged 1 commit into from
Jul 6, 2023

Conversation

NotMyFault
Copy link
Member

No description provided.

@NotMyFault NotMyFault requested a review from a team as a code owner July 6, 2023 08:07
@NotMyFault NotMyFault merged commit 8109e76 into master Jul 6, 2023
@NotMyFault NotMyFault deleted the cd branch July 6, 2023 08:26
jglick
jglick reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sanity-check everything since I do not know of any precedent for JEP-229 being used on a Maven plugin.

.github/release-drafter.yml
@@ -1,3 +1,3 @@
# https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc
_extends: .github
tag-template: maven-license-plugin-$NEXT_MINOR_VERSION
tag-template: license-maven-plugin-$NEXT_MINOR_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be deleted for JEP-229. See instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

@timja timja timja approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotMyFault @jglick @timja