Add label verifier localization support #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pom.xml没改，晚点我看看
YanJun Shi <siiyanjun@gmail.com> 于 2019年10月3日周四 10:49写道：
… 嗯？除了配置文件还有要改的是吗
Zhao Xiaojie ***@***.***> 于 2019年10月3日周四 08:18写道：
> ***@***.**** requested changes on this pull request.
>
> pom.xml
> <https://github.com/jenkinsci/localization-zh-cn-plugin/blob/master/pom.xml>
> 文件也需要修改的，本地测试通过了？
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#109?email_source=notifications&email_token=AE47N3JVAAW76MEGHMTYLG3QMU265A5CNFSM4I4RYCGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGWZ6DI#pullrequestreview-296591117>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AE47N3LPR5RZJRZJFGO5ODDQMU265ANCNFSM4I4RYCGA>
> .
>
|
|
嗯？除了配置文件还有要改的是吗
Zhao Xiaojie <notifications@github.com> 于 2019年10月3日周四 08:18写道：
… ***@***.**** requested changes on this pull request.
pom.xml
<https://github.com/jenkinsci/localization-zh-cn-plugin/blob/master/pom.xml>
文件也需要修改的，本地测试通过了？
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=AE47N3JVAAW76MEGHMTYLG3QMU265A5CNFSM4I4RYCGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGWZ6DI#pullrequestreview-296591117>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE47N3LPR5RZJRZJFGO5ODDQMU265ANCNFSM4I4RYCGA>
.
|
|
See JEP-216 for design details. 没有其他的了，在 readme 中有链接和描述。 |
|
pom.xml已经加上了
…On Thu, Oct 3, 2019 at 1:41 PM Zhao Xiaojie ***@***.***> wrote:
See JEP-216
<https://github.com/jenkinsci/jep/blob/master/jep/216/README.adoc> for
design details.
没有其他的了，在 readme 中有链接和描述。
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=AE47N3KT4NASZRB2G3YPLK3QMWAZXA5CNFSM4I4RYCGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAHB4TI#issuecomment-537796173>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE47N3P4EUWBQA4U2QY4E23QMWAZXANCNFSM4I4RYCGA>
.
|
LinuxSuRen
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter checklist
Desired reviewers
@jenkinsci/chinese-localization-sig
Fix #61