Add localization for Bitbucket Branch Source plugin #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
为啥这个commit hisotry这么奇怪，你合并的时候是不是用的rebase啊 😂 |
|
你是基于最新的 master 分支来新建的分支吗？ |
|
是啊，修改前我也pull下来更新了。 |
|
那不应该出现这种情况的，你先把 master 更新为最新的，然后再基于 master 创建新的分支，最后修改（添加）文件。 |
|
@LinuxSuRen 这个PR merge掉吧，还是我改改我本地的hisotry，然后强制push上来？下次我注意一下。 |
|
晚一点 review 下，我也可以 squash |
|
OK，谢谢啦 |
|
Jenkins 中其他地方的 Credentials 翻译为凭据，我们需要统一下 |
LinuxSuRen
reviewed
Oct 9, 2018
| @@ -0,0 +1,2 @@ | |||
| Name=\u547d\u540d | |||
There was a problem hiding this comment.
因为这里是给一个 server endpoint 设置名称
The human friendly name for this Bitbucket server endpoint.
我当时觉得命名这个翻译会好一点，不过好像名称就行了。
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jenkinsci/chinese-localization-sig