Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation for github branch source plugin #19

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Add translation for github branch source plugin #19

merged 1 commit into from
Oct 28, 2018

Conversation

xuesea
Copy link

@xuesea xuesea commented Oct 16, 2018 •
edited
Loading

Submitter checklist

Desired reviewers

@jenkinsci/chinese-localization-sig

LinuxSuRen
LinuxSuRen requested changes Oct 25, 2018
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.classpath 等和项目相关的配置文件不需要提交。可以把这些配置加入到 .gitignore 中。

LinuxSuRen
LinuxSuRen requested changes Oct 25, 2018
View reviewed changes
...rce-plugin/src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties Outdated
@@ -0,0 +1,57 @@
BranchSCMHead.Pronoun=Branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文对应的文件，也不需要提交。

.../jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/help-strategyId.html Outdated
@@ -0,0 +1,18 @@
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个也是英文的。

@xuesea
Copy link
Author

xuesea commented Oct 27, 2018

给无关文件加入了 .gitignore 中，移除了很多原文文件。

LinuxSuRen
LinuxSuRen approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxSuRen LinuxSuRen merged commit 837cd3e into jenkinsci:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuesea @LinuxSuRen