Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization for Code Coverage API plugin #5

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Add localization for Code Coverage API plugin #5

merged 3 commits into from
Sep 28, 2018

Conversation

cizezsy
Copy link
Contributor

@cizezsy cizezsy commented Sep 27, 2018 •
edited
Loading

@jenkinsci/chinese-localization-sig

LinuxSuRen
LinuxSuRen reviewed Sep 27, 2018
View reviewed changes
...ain/resources/io/jenkins/plugins/coverage/CoverageProjectAction/floatingBox_zh_CN.properties Outdated
@@ -0,0 +1 @@
Code\ Coverage=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要内容？

LinuxSuRen
LinuxSuRen requested changes Sep 28, 2018
View reviewed changes
...gin/src/main/resources/io/jenkins/plugins/coverage/CoveragePublisher/config_zh_CN.properties Outdated
@@ -0,0 +1,2 @@
Global\ Option=\u5168\u5c40\u9009\u9879
Global\ Thresholds=\u5168\u5c40Thresholds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的中英文之间加上空格

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我之前加了空格，发现看着不是特别舒服，就删掉了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那我还是加上吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，还是按照咱们定的规范来比较好

@LinuxSuRen LinuxSuRen merged commit 79ec996 into jenkinsci:master Sep 28, 2018
@cizezsy
Copy link
Contributor Author

cizezsy commented Sep 28, 2018

@LinuxSuRen CI 因为 Findbugs 不通过，失败了啊，要不要我改改代码，让它通过？还是你自己改。

@LinuxSuRen
Copy link
Member

@cizezsy 注意到了，我来改吧

@cizezsy
Copy link
Contributor Author

cizezsy commented Sep 28, 2018

@LinuxSuRen OK :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cizezsy @LinuxSuRen