Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed brackets in lockable-resources.js #724

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin commented Oct 29, 2024

See #722.

Testing done

Go to lockable resources page, observe there's an error in the dev console before the change. Reserve button doesn't work.

After the change there's no error, reserve/unreserve buttons work as expected.

Before the change
After the change

Proposed upgrade guidelines

N/A

Localizations

  • English
  • German
  • French
  • Slovak
  • Czech
  • ...

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transferred to *.properties files.
  • Changes in the interface are documented also as examples.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically. See also release-drafter-labels.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner October 29, 2024 11:47
@yaroslavafenkin
Copy link
Contributor Author

@basil PTAL when you're around

Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, but please fill the PR description from template.
How you test it? Some screenshots. Why we missed automated test cases? .....
All this informations are helpfull in the review process checking the history make it also much more easy.

@yaroslavafenkin
Copy link
Contributor Author

The change looks fine, but please fill the PR description from template. How you test it? Some screenshots. Why we missed automated test cases? ..... All this informations are helpfull in the review process checking the history make it also much more easy.

Both CSP PRs that I've filed before were fine individually. The lack of bracket is caused by a merge accident. Seems to be first introduced in c0ba76f. Videos of testing of those changes are in the corresponding pull requests.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the trouble and thanks for fixing this.

@basil basil added the bug label Oct 29, 2024
@basil basil merged commit 8cf9c29 into jenkinsci:master Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants