Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when using insecure auth #275

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Mar 11, 2024

Additionally if running in FIPS use an error in the form validation and do not support auth without SSL or TLS.

This is handled when we attempt to send as the config is part of the global configuration and could leave the config in an non determinate state

Testing done

Submitter checklist

@jtnord jtnord requested a review from a team as a code owner March 11, 2024 18:23
jglick
jglick previously approved these changes Mar 11, 2024
@jglick
Copy link
Member

jglick commented Mar 11, 2024

but

java.lang.AssertionError: 

Expected: is <OK: <div/>>
     but: was <OK>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at hudson.tasks.MailerTest.authenticationFormValidation(MailerTest.java:307)

Additionally if running in FIPS use an error in the form validation and
do not support auth without SSL or TLS.

This is handled when we attempt to send as the config is part of the
global configuration and could leave the config in an non determinate
state
@jglick jglick added this pull request to the merge queue Mar 12, 2024
Merged via the queue into jenkinsci:master with commit f7c289a Mar 12, 2024
17 checks passed
@jtnord jtnord deleted the auth-without-security branch March 12, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants