Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-64523 Jenkins core >2.263 fixes #23

Merged
merged 3 commits into from
Dec 31, 2020

Conversation

timja
Copy link
Member

@timja timja commented Dec 29, 2020

  • Replace Hudson mentions with Jenkins
  • Add @Symbol to the build wrapper
  • Fix config page mess caused by very high ordinal placing it above Jenkins core widgets in system configuration
  • Merge sections in system configuration to one, it looked very strange with 3
  • Convert tables to divs in form layout, note this heavily used tables for layout and I've dropped compatibility with old core to make this easier to implement, understand and maintain.
  • Add bom
  • Remove workspace requirement for build wrapper (requires somewhat new core (not sure exact version))
  • Correct documentation about pipeline being supported for global setting (it's not)
  • Implement data-binding for build wrapper, I haven't updated the configure method because this plugin uses a super weird pattern where it's describeable object doesn't store the configuration it uses a PoJo then writes directly to the XML file manually. This is a start towards JCasC support if someone wants to implement it

@oleg-nenashev

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good from what I can tell, have not tested manually yet. There is an issue with breaking API changes which may cause regressions in the downstream, but I cannot estimate the impact.

There are also a few other unrelated changes, but they should be safe enough

pom.xml Outdated Show resolved Hide resolved
@timja
Copy link
Member Author

timja commented Dec 30, 2020

This change looks good from what I can tell, have not tested manually yet. There is an issue with breaking API changes which may cause regressions in the downstream, but I cannot estimate the impact.

There are also a few other unrelated changes, but they should be safe enough

I did github searches and I couldn't see any issue, yes there's a risk...

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Copy link

@res0nance res0nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May cause some issues if there are anyone depending on this, but IMO better to move forward

@oleg-nenashev oleg-nenashev merged commit 79e151f into jenkinsci:master Dec 31, 2020
@timja timja deleted the tables-to-divs branch December 31, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants