Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deeper spotbugs checks #44

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Deeper spotbugs checks #44

merged 2 commits into from
Mar 15, 2023

Conversation

pushker001
Copy link
Contributor

Increase the efficiency of checking spots-bug

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@pushker001
deeper spot-bugs checks
2da4beb 
Increase the efficiency of checking spots-bug
MarkEWaite
MarkEWaite requested changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please remove the spotbugs.failOnError setting since it is a duplicate of the default setting

pom.xml Outdated Show resolved Hide resolved
@pushker001 @MarkEWaite
Update pom.xml
46fff09 
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@MarkEWaite MarkEWaite changed the title deeper spot-bugs checks deeper spotbugs checks Mar 15, 2023
@MarkEWaite MarkEWaite changed the title deeper spotbugs checks Deeper spotbugs checks Mar 15, 2023
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort label Mar 15, 2023
@pushker001
Copy link
Contributor Author

@MarkEWaite I want to write a contributing guide for this plugin can you provide me some material to write in contributing guide

@MarkEWaite
Copy link
Contributor

@MarkEWaite I want to write a contributing guide for this plugin can you provide me some material to write in contributing guide

Samples are available at https://www.jenkins.io/doc/developer/tutorial-improve/add-a-contributing-guide/

@MarkEWaite MarkEWaite enabled auto-merge (squash) March 15, 2023 13:57
@MarkEWaite MarkEWaite merged commit 0216d54 into jenkinsci:master Mar 15, 2023
@pushker001
Copy link
Contributor Author

@MarkEWaite wants to write the contributing guide for this plugin can you provide some sources to write the contributing guide

@pushker001 pushker001 deleted the sportbugs-check branch March 15, 2023 14:18
@MarkEWaite
Copy link
Contributor

@MarkEWaite wants to write the contributing guide for this plugin can you provide some sources to write the contributing guide

No, I won't provide more sources than are already provided in https://www.jenkins.io/doc/developer/tutorial-improve/add-a-contributing-guide/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces maintenance effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushker001 @MarkEWaite